[vlc-devel] [PATCH] configure: Support systems with popcount(3) and popcountll(3)

[Kamil Rytarowski]

Meanwhile, I will prepare patches for vlc HEAD, they will use a little
bit more complicated approach:

 - rename popcount() to vlc_popcount()
 - detect libc's popcount{,l,ll}() and reuse it otherwise fallback to
__builtin_popcount{,l,ll}()

On 25.02.2018 12:12, Thomas Guillem wrote:
> Rémi, could explain what this patch is breaking ?
> 
> The patch "configure: Add a new test for <locale.h>" apply for 3.0, builds, run and pass the make check for me.
> 
> On Sun, Feb 25, 2018, at 12:10, Kamil Rytarowski wrote:
>> On 25.02.2018 12:01, Rémi Denis-Courmont wrote:
>>> Le sunnuntaina 25. helmikuuta 2018, 13.00.17 EET Kamil Rytarowski a écrit :
>>>> On 25.02.2018 11:56, Rémi Denis-Courmont wrote:
>>>>> Le lauantaina 24. helmikuuta 2018, 13.38.43 EET Kamil Rytarowski a écrit :
>>>>>> And since the already submitted patch is prepared for 3.0, could we
>>>>>> please merge it with 3.0?
>>>>>
>>>>> The patch actually breaks the test suite on VLC 3.0, so no.
>>>>
>>>> What platform is broken? Can I see the failure log?
>>>
>>> I did not save the log but I think all platforms break anyway.
>>>
>>
>> This fixes one build problem on NetBSD/amd64. I don't see anything wrong
>> with the patch. Please redo testing, I need to know what to address.
>>
>> I plan to send more similar afterwards (e.g. bswap32 is in the NetBSD libc).
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> Email had 1 attachment:
>> + signature.asc
>>   1k (application/pgp-signature)
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 850 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180225/ed4bec19/attachment.sig>