[vlc-devel] [PATCH] Configure: find LUAC in srcdir/bin, rather than in contrib dir. If contribs were built using a prefix, ${CONTRIB_DIR} will point to that prefix and ${CONTRIB_DIR}/../bin will be an invalid location where to find luac.

[Rémi Denis-Courmont]

Le tiistaina 27. helmikuuta 2018, 16.53.48 EET Marvin Scholz a écrit :
> On 27 Feb 2018, at 15:44, Rémi Denis-Courmont wrote:
> > Le 27 février 2018 16:39:07 GMT+02:00, Marvin Scholz
> > 
> > <epirat07 at gmail.com> a écrit :
> >> On 27 Feb 2018, at 15:34, Rémi Denis-Courmont wrote:
> >>> I don't understand the problem nor the solution TBH.
> >> 
> >> If I am not mistaken, I think I ran into the same problem.
> >> The path where the luac tool is installed to does not in all
> >> cases seem to match the path where configure tries to find it.
> >> 
> >> As stated in the previous email:
> >>>> In my case, luac Is still installed under /vlc/contrib/bin,
> >>>> but the configure script is assuming luac to be found under
> >>>> /build-tools/../bin/, which is wrong.
> >> 
> >> So either install location of luac needs to be fixed,
> >> installing something outside prefix seems weird…
> >> Or configure needs to be fixed to look in the correct place,
> >> at least.
> >> 
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> > 
> > That is what I don't understand. AFAIK, the Lua "cross-compiler" is
> > output by contribs into $top_srcdir/contrib/bin as $tripplet-luac
> > always.
> 
> It installs to:
> 
> 	mkdir -p -- $(BUILDBINDIR)
> 	install -m 0755 -s -- $</src/luac $(BUILDBINDIR)/$(HOST)-luac
> 
> And BUILDBINDIR is set to:
> 
> 	BUILDPREFIX ?= $(TOPDST)
> 	BUILDPREFIX := $(abspath $(BUILDPREFIX))
> 
> […]
> 
> 	BUILDBINDIR ?= $(BUILDPREFIX)/bin
> 
> and TOPDST is set to:
> 
> 	TOPDST ?= ..
> 
> So maybe TOPSRC is what should be used there instead of TOPDST?

Normally, they are the same. They will only differ if building contrib from a 
VLC build subdirectory. In that case, TOPSRC will point to the contirb source 
and TOPDST to the contrib build. I doubt that this feature still works though, 
as it is probably not used and maintained by anybody.

Also, I don't see how it relates to this patch.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/