[vlc-devel] [vlc-commits] stream_filter: skiptags: return truncated size (fix #19390)

[Rémi Denis-Courmont]

On mardi 2 janvier 2018 09:25:23 EET Francois Cartegnie wrote:
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Tue Jan  2
> 10:18:16 2018 +0100| [2080dcb8e3aa936a0839c0ce5d85123f8170b875] |
> committer: Francois Cartegnie
> 
> stream_filter: skiptags: return truncated size (fix #19390)
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2080dcb8e3aa936a083
> > 9c0ce5d85123f8170b875
> ---
> 
>  modules/stream_filter/skiptags.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/modules/stream_filter/skiptags.c
> b/modules/stream_filter/skiptags.c index 5399cbb4e0..529f2bca1c 100644
> --- a/modules/stream_filter/skiptags.c
> +++ b/modules/stream_filter/skiptags.c
> @@ -178,6 +178,11 @@ static int Control(stream_t *stream, int query, va_list
> args) *va_arg( args, const block_t ** ) = sys->p_tags;
>          return VLC_SUCCESS;
>      }
> +    else if(query == STREAM_GET_SIZE)
> +    {
> +        *va_arg(args, uint64_t *) = stream_Size(stream->s) -
> sys->header_skip; +        return VLC_SUCCESS;
> +    }

Obvious underflow on error.

-- 
Rémi Denis-Courmont