[vlc-devel] [PATCH] avcodec: set profile in the ES descriptor if not already defined

[Mathieu Velten]

Le mar. 2 janv. 2018 à 14:30, Thomas Guillem <thomas at gllm.fr> a écrit :

> Hello,
>
> dec->fmt_in should not be written from decoder modules.
>
> I already merged your VP9 vaapi patch. Was I too fast ?


Fine for me, I was answering the last comment of Steve.
Both solutions are fine for me so let's keep it like that if nobody objects.


Le mar. 2 janv. 2018 à 15:00, Francois Cartegnie <fcvlcdev at free.fr> a
écrit :

> Le 02/01/2018 à 14:26, Mathieu Velten a écrit :
> >
> > +    /* Sometimes the profile is not available through the container
> metadatas
> > +     * and not provided by the packetizer either (VP9 in WebM) */
> > +    if (p_dec->fmt_in.i_profile < 0 && p_context->profile > 0)
> > +        p_dec->fmt_in.i_profile = p_context->profile;
>
> Again, the ffmpeg defines are not usable on vlc structs.
>

I checked after what you said and it looks like standardize value defined
by the decoder standard, at least for H264/HEVC/VP9.

Anyway the merged patch is better in this regard this I compare the avcodec
ctx value to the FF constant.


>
> --
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180102/ac23ec9e/attachment.html>