[vlc-devel] [RFC PATCH 1/3] picture: add display orientation

[Rémi Denis-Courmont]

Le 2 janvier 2018 17:17:12 GMT+01:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>On Fri, Dec 22, 2017, at 20:30, Rémi Denis-Courmont wrote:
>> Le torstaina 21. joulukuuta 2017, 18.08.53 EET Thomas Guillem a écrit
>:
>> > In order to allow filters to modify the orientation without
>touching picture
>> > data.
>> 
>> You can already do that by changing the output format of the filter.
>
>Sorry for the late reply. If you change the filter fmt_out, the core
>will try to add a filter to compensate for format changes. So you'll
>have the first filter that will transform W x H to H x W and the adapt
>one that will try to fit H x W into W x H. It works for cpu formats,
>but do a lot of memcpy. I don't think we can adapt our usecase here.
>
>> 
>> There are likely still some broken assumptions in the filter chain
>and/or vout 
>> code, either way.
>> 
>> -- 
>> 雷米‧德尼-库尔蒙
>> https://www.remlab.net/
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

There are no (legitimate) reasons why the picture would be rescaled. That would be a bug just as well on CPU surfaces. And there are no risks of memcpy() penalties here; that problem only exists for CPU surfaces.
-- 
Remi Denis-Courmont