[vlc-devel] [PATCH] stream_extractor/archive: Check for NULL return of archive_entry_pathname

[Marvin Scholz]

On 5 Jan 2018, at 17:19, Thomas Guillem wrote:

> On Fri, Jan 5, 2018, at 17:12, Marvin Scholz wrote:
>> Fixes crash 2a1e0ab3-e9d5-433c-afd8-ec56e6a8968f
>
> Maybe mention breakpad instead of crash.
>

Ok

>> ---
>>  modules/stream_extractor/archive.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/modules/stream_extractor/archive.c b/modules/
>> stream_extractor/archive.c
>> index 4fdb3b1378..9396c34c3e 100644
>> --- a/modules/stream_extractor/archive.c
>> +++ b/modules/stream_extractor/archive.c
>> @@ -516,6 +516,10 @@ static int ReadDir( stream_directory_t*
>> p_directory, input_item_node_t* p_node )
>>              continue;
>>
>>          char const* path = archive_entry_pathname( entry );
>> +
>> +        if( unlikely( !path ) )
>> +            break;
>
> Maybe continue here. I guess you don't have the sample ?
>

I don't have a sample to try, I am not sure what might be the best
approach here. I just did the same as for the 
vlc_stream_extractor_CreateMRL
failure as it seemed similar.

>> +
>>          char*       mrl  = vlc_stream_extractor_CreateMRL( 
>> p_directory, path );
>>
>>          if( unlikely( !mrl ) )
>> -- 
>> 2.14.3 (Apple Git-98)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel