[vlc-devel] [PATCH] esformat/video: fix & improve transformation logic

[jnqnfe at gmail.com]

At the moment I am largely working without internet access,
occasionally travelling somewhere about once a week at most to get it,
and I am just about to leave, it's already late, so not ideal for
fulfilling your request. Sorry.

I did (before submitting) extract the core transform logic as a small
Rust program with a complete set of unit tests, to check and be certain
about the existing and new calculations (in the core functions) across
all 64 orientation combinations. This is where i got the 24/64 and
32/64 numbers from. The new calculations gave 64/64.

I am affraid I can't do much more at this moment in time :/

Regards,
Lyndon

On Fri, 2018-01-05 at 19:40 +0100, Jean-Baptiste Kempf wrote:
> Hello Lyndon,
> 
> Thanks a lot for your patch.
> 
> I have to say that I'm surprised we have so much wrong here, but it's
> always very possible.
> 
> Please split this patch in smaller patches (git add -p is a magic).
> Please also check that all samples from https://streams.videolan.org/
> issues/2882/ are still correctly disabled, with and without hardware
> decoding.
> 
> Best,
> 
> On Fri, 5 Jan 2018, at 19:10, jnqnfe at gmail.com wrote:
> > patch attached
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > Email had 1 attachment:
> > + transform_fixes.patch
> >   27k (text/x-patch)
> 
>