[vlc-devel] ?= [PATCH=?utf-8?q? 0/2] srt: Use CreateEvent instead of vlc_pipe for Win32

[Rémi Denis-Courmont]

Le 8 janvier 2018 14:49:51 GMT+08:00, Justin Kim <justin.kim at collabora.co.uk> a écrit :
>If I am too hasty, I'm sorry.
>But I'd like to  get some advice about this approach.
>
>Thanks,
>Justin
>
>On Thursday, January 04, 2018 13:45 KST, Justin Kim
><justin.kim at collabora.com> wrote: 
> 
>> Apparently, vlc_pipe seems not to support Win32, and SRT library
>doesn't
>> have epoll-like feature too. Therefore, I tried to use WinAPI
>directly.
>> 
>> I have sent a patch as RFC few weeks ago, but it never be shown in
>the
>> mailing list. I think there was a problem while sending the patch.
>> 
>> Please, review these commits.
>> 
>> BR,
>> Justin
>> 
>> Justin Kim (2):
>>   access: srt: Interrupt by WINAPI
>>   access_out: srt: Interrupt by WINAPI
>> 
>>  modules/access/srt.c        | 50
>++++++++++++++++++++++++++++++++++++++++---
>>  modules/access_output/srt.c | 52
>+++++++++++++++++++++++++++++++++++++++++++--
>>  2 files changed, 97 insertions(+), 5 deletions(-)
>> 
>> -- 
>> 2.7.4
>>
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

To be honest, using proper wake-up mechanism is great... but then having a poll timeout makes no sense anymore.

Also it feels like the SRT library API is really inconvenient. It would be far simpler to return the set of sockets and events from the library and let the caller do the polling. Like ALSA (and many others).
-- 
Remi Denis-Courmont