[vlc-devel] [PATCH] Configure: find LUAC in srcdir/bin, rather than in contrib dir. If contribs were built using a prefix, ${CONTRIB_DIR} will point to that prefix and ${CONTRIB_DIR}/../bin will be an invalid location where to find luac.

[jeremy.vignelles at dev3i.fr]

I tried using ${srcdir} but it is a relative path. $LUAC would contain something like `../contrib/bin` (simplified for example), but the command is invoked in a subfolder, causing the command to fail.

I also tried ${abs_srcdir} which doesn't seem to be available at configure time, so I did it that way. I hope this is portable.

Feel free to ask if you have any other question.

-----Message d'origine-----
De : vlc-devel [mailto:vlc-devel-bounces at videolan.org] De la part de Marvin Scholz
Envoyé : lundi 8 janvier 2018 16:19
À : Mailing list for VLC media player developers <vlc-devel at videolan.org>
Objet : Re: [vlc-devel] [PATCH] Configure: find LUAC in srcdir/bin, rather than in contrib dir. If contribs were built using a prefix, ${CONTRIB_DIR} will point to that prefix and ${CONTRIB_DIR}/../bin will be an invalid location where to find luac.

Thanks for your patch!

On 8 Jan 2018, at 16:07, Jeremy Vignelles wrote:

> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac index 030832e..e4e9c74 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -440,8 +440,8 @@ AS_IF([test -n "${CONTRIB_DIR}"], [
>      ])
>
>      dnl Newer contribs follow usual name space rules
> -    AS_IF([test -x 
> "${CONTRIB_DIR}/../bin/${host_alias}-luac${BUILDEXEEXT}"], [
> -      LUAC="${CONTRIB_DIR}/../bin/${host_alias}-luac${BUILDEXEEXT}"
> +    AS_IF([test -x
> "${srcdir}/contrib/bin/${host_alias}-luac${BUILDEXEEXT}"], [
> +      LUAC="`cd ${srcdir} &&
> pwd`/contrib/bin/${host_alias}-luac${BUILDEXEEXT}"

Why aren't you using 
"${srcdir}/contrib/bin/${host_alias}-luac${BUILDEXEEXT}" here?

>      ])
>    ])
>
> -- 
> 2.10.1.windows.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel