[vlc-devel] [PATCH] input: Don't probe the stream when controlling a demux_Filter

[Rémi Denis-Courmont]

Le torstaina 11. tammikuuta 2018, 6.47.07 EET Rémi Denis-Courmont a écrit :
> Le torstaina 11. tammikuuta 2018, 6.38.12 EET Rémi Denis-Courmont a écrit :
> > This is UB even with the patch, only much  more needlessly complicated.
> > Nack.
> > 
> > We have been through this timed and times already.
> 
> The problem is that a2beb67ed7 is not compatible with demux filters, and
> never was. Yet it was not rolled back when demux filters were added.
> 
> This patch does not fix that because it still ends up violating the
> threading and ownership rules. Either demux filters are not taken into use
> or a2beb67ed7 is reverted

Or carry on the existing hack: implement DEMUX_CAN_PAUSE, 
DEMUX_CAN_CONTROL_PACE and DEMUX_GET_PTS_DELAY in all demux filters. It should 
already be implemented in all stream_demuxers and asynchronous demuxers, to 
maintain the assumptions made in a2beb67ed7.

But that´s the ugliest and most confusing option. I´d much rather revert 
a2beb67ed7.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/