[vlc-devel] [PATCH] qt: fix file url when converting / opening multiple files

Pierre Lamot pierre at videolabs.io
Thu Jan 11 09:55:56 CET 2018


> > -                newFileName = fileLine->text();
> > +                if( fileLine->text().startsWith("file://") )
> > +                    newFileName = QUrl(fileLine->text()).toLocalFile();
> > +                else
> > +                    //user have set up a path manually
> > +                    newFileName = fileLine->text();
> 
> This cannot be right. You canĀ“t (unambiguously) mix URLs and file paths.

I thought about this, I wanted to be more laxist about user input, accepting 
path when entered manulally (Qt file selector returning an url). I OK to accept 
path only, Then I'll probably set the field as non editable manually to avoid 
ambiguity.

--
Pierre Lamot



More information about the vlc-devel mailing list