[vlc-devel] [PATCH] esformat/video: fix & improve transformation logic

[jnqnfe at gmail.com]

Reworked patch into set of 9, attached :)

On Sat, 2018-01-06 at 16:17 +0100, Jean-Baptiste Kempf wrote:
> Hello Lyndon,
> 
> On Fri, 5 Jan 2018, at 21:28, jnqnfe at gmail.com wrote:
> > At the moment I am largely working without internet access,
> > occasionally travelling somewhere about once a week at most to get
> > it,
> > and I am just about to leave, it's already late, so not ideal for
> > fulfilling your request. Sorry.
> 
> OK. But you know that re-creating patches does not require Internet!
> Git is a powerful friend ;)

Yes, but 1) it means waiting a while for me to get the new patches to
you, and 2) you'd asked me to do some testing with some sample videos
and the one time I tried compiling VLC months ago, I remember it taking
1hr+ and requiring internet access to retrieve contrib sources (over a
not particularly fast connection). Also, I am not currently in a good
position to compile VLC in one other respect, having moved to Linux I
have not got a good build env set up for non-Rust projects, I tried
sbuild months ago, but if I remember correctly I was having trouble
figuring out how to make the env persistent, such that I could re-
compile with patches without it starting from scratch, and I haven't
had the time to sort this out properly, so I'm left submitting the odd
VLC patch without being able to compile them first. :/

> > I did (before submitting) extract the core transform logic as a
> > small
> > Rust program with a complete set of unit tests, to check and be
> > certain
> > about the existing and new calculations (in the core functions)
> > across
> > all 64 orientation combinations. This is where i got the 24/64 and
> > 32/64 numbers from. The new calculations gave 64/64.
> 
> OK.
> 
> > I am affraid I can't do much more at this moment in time :/
> 
> I am not sure we're in a huge hurry, tbh.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: transform_fixes_v2.zip
Type: application/zip
Size: 10815 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180112/3f901f68/attachment.zip>