[vlc-devel] [PATCH] create cookies storage on libvlcmediaplayer

[Thomas Guillem]

On Wed, Jan 17, 2018, at 08:26, Steve Lhomme wrote:
> Seems right as that's the same code as in playlist/engine.c

And all will be merged on VLC 4.0.

LGTM

> 
> Le 16/01/2018 à 21:56, Francois Cartegnie a écrit :
> > ---
> >   lib/media_player.c | 17 +++++++++++++++++
> >   1 file changed, 17 insertions(+)
> >
> > diff --git a/lib/media_player.c b/lib/media_player.c
> > index 6e00a4547f..a9a22fee15 100644
> > --- a/lib/media_player.c
> > +++ b/lib/media_player.c
> > @@ -36,6 +36,7 @@
> >   #include <vlc_vout.h>
> >   #include <vlc_aout.h>
> >   #include <vlc_actions.h>
> > +#include <vlc_http.h>
> >   
> >   #include "libvlc_internal.h"
> >   #include "media_internal.h" // libvlc_media_set_state()
> > @@ -724,6 +725,15 @@ libvlc_media_player_new( libvlc_instance_t *instance )
> >       var_Create (mp, "equalizer-vlcfreqs", VLC_VAR_BOOL);
> >       var_Create (mp, "equalizer-bands", VLC_VAR_STRING);
> >   
> > +    /* Initialize the shared HTTP cookie jar */
> > +    vlc_value_t cookies;
> > +    cookies.p_address = vlc_http_cookies_new();
> > +    if ( likely(cookies.p_address) )
> > +    {
> > +        var_Create(mp, "http-cookies", VLC_VAR_ADDRESS);
> > +        var_SetChecked(mp, "http-cookies", VLC_VAR_ADDRESS, cookies);
> > +    }
> > +
> >       mp->p_md = NULL;
> >       mp->state = libvlc_NothingSpecial;
> >       mp->p_libvlc_instance = instance;
> > @@ -818,6 +828,13 @@ static void libvlc_media_player_destroy( libvlc_media_player_t *p_mi )
> >       libvlc_media_release( p_mi->p_md );
> >       vlc_mutex_destroy( &p_mi->object_lock );
> >   
> > +    vlc_http_cookie_jar_t *cookies = var_GetAddress( p_mi, "http-cookies" );
> > +    if ( cookies )
> > +    {
> > +        var_Destroy( p_mi, "http-cookies" );
> > +        vlc_http_cookies_destroy( cookies );
> > +    }
> > +
> >       libvlc_instance_t *instance = p_mi->p_libvlc_instance;
> >       vlc_object_release( p_mi );
> >       libvlc_release(instance);
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel