[vlc-devel] [PATCH] aout: do not reset the instance volume to -1 on destroy

[Steve Lhomme]

Le 17/01/2018 à 19:06, Rémi Denis-Courmont a écrit :
> Le keskiviikkona 17. tammikuuta 2018, 18.53.04 EET Steve Lhomme a écrit :
>> There might be other modules started that have already set their proper
>> value.
> First, that wouldn´t actually fix the problem - the reported value is whatever

I'm not sure if you're referring to my code or the sentence in the 
commit log. If it's for the code I can tell you it fixes that particular 
issue.

> the last update of any aout was. It is not meaningful with more than one aout.
>
> And then, there cannot be more than one concurrent aout per input with the
> default ES output parameters.

During playback yes. But when switching aout that's not what the code does.

In input/decoder.c there's a input_resource_GetAout() which creates the 
new aout (sets the volume) and then a
input_resource_PutAout() (destroys the previous aout, resets the volume).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180118/30f7458d/attachment.html>