[vlc-devel] [PATCH] esformat/video: fix & improve transformation logic

[jnqnfe at gmail.com]

Appologies for not responding to this when I sent out patch v2, your
response had found its way into my spam folder for some reason and I've
only just seen it.

Please review v2 which broke the changes up into a set of 9 patches. At
 least the first five should be acceptable before we hit your
objection.

When it comes to your objection itself, I am not sure that I follow. I
am curious that you may have misunderstood my "FIXME: remove? no useful
purpose?" comment against TRANSFORM_IDENTITY as also applying to the
other three aliases below (TRANSFORM_VFLIP, TRANSFORM_TRANSPOSE and
TRANSFORM_ANTI_TRANSPOSE), which is not the case.

On Tue, 2018-01-09 at 13:33 +0200, Rémi Denis-Courmont wrote:
> On vendredi 5 janvier 2018 18:10:40 EET jnqnfe at gmail.com wrote:
> > patch attached
> 
> I don't agree. Transposition and anti-transposition are involutive,
> so it made 
> perfect sense that the transform and the orientation were aliased -
> as for any 
> pair of orientation and transform other than +/-90 degrees rotation.
> 
> This patch seems to mistake them and I stopped reviewing at that
> point.
>