[vlc-devel] [PATCH] Fix VLCKit build script for MacOSX 10.13

[David Fuhrmann]

> Am 24.01.2018 um 17:33 schrieb adampcc at runbox.com:
> 
> From: Adam Fedor <adampcc at runbox.com>
> 
> This patch fixes and issue with compiling VLCKit/vlc on later MacOSX systems using the build script. 
> See https://code.videolan.org/videolan/VLCKit/issues/131
> 
> ---
> buildVLCKit.sh | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/buildVLCKit.sh b/buildVLCKit.sh
> index bc18a6e..df6f38f 100755
> --- a/buildVLCKit.sh
> +++ b/buildVLCKit.sh
> @@ -162,6 +162,8 @@ buildLibVLC() {
> 
>     export PATH="${VLCROOT}/extras/tools/build/bin:${VLCROOT}/contrib/x86_64-apple-darwin15/bin:$PATH"
> 
> +    export ac_cv_func_open_memstream=no
> +

Hi,

You should blacklist all missing symbols, they are far more. See build.sh in vlc.git repo.

As this would duplicate quite a much lines: Could you maybe investigate if just executing build.sh in this script here would be a possible option, to avoid duplication?

Thanks.

BR. David

>     info "Building tools"
>     spushd extras/tools
>     ./bootstrap
> @@ -214,6 +216,7 @@ buildLibVLC() {
>     spushd vlckitbuild
> 
>     ../configure --build=${TARGET} --prefix="${PREFIX}" \
> +        --with-macosx-version-min=${SDK_MIN} \
>         --disable-macosx \
>         --enable-merge-ffmpeg \
>         --disable-sparkle \
> -- 
> 2.14.3 (Apple Git-98)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel