[vlc-devel] [PATCH] vlc_strftime: avoid infinite loop on windows when format string is invalid

[Rémi Denis-Courmont]

Le torstaina 25. tammikuuta 2018, 18.24.44 EET Pierre Lamot a écrit :
> > The problem is not really specific to Windows, is it? You cannot rely on
> > Windows or glibc extensions then (and I don't see why you would need to
> > either but I have not tried).
> 
> The problem depends upon the implementation of strftime.

No.

> Posix states that the behavior is undefined if a conversion character is
> unknown

We can intrinsically not handle UB and therefore we do not handle UB, at least 
not post-facto. Where practical and useful, you can add post-facto assertions 
to aid in debugging - nothing else.

> The issue can be seen on windows when changing the text of the marquee
> filter.

There are plenty of ways to crash VLC within valid input parameters. We just 
have to ensure that any such parameter is _not_ marked safe. Preventing UB is 
impossible and therefore out of scope.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/