[vlc-devel] [PATCH] avcodec: assume a source is full range if not specified and an RGB format

Steve Lhomme robux4 at ycbcr.xyz
Mon Jan 29 09:02:51 CET 2018


There's a good chance that codec decoding to RGB are capture formats from
computers using full range display.

Ref #19127

--
replaces https://patches.videolan.org/patch/19475/
- explain it's a workaround and a cleaner fix is needed
---
 modules/codec/avcodec/video.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/modules/codec/avcodec/video.c b/modules/codec/avcodec/video.c
index 6d2cf4458a..c763a2d754 100644
--- a/modules/codec/avcodec/video.c
+++ b/modules/codec/avcodec/video.c
@@ -205,8 +205,21 @@ static int lavc_GetVideoFormat(decoder_t *dec, video_format_t *restrict fmt,
                                  * __MAX(ctx->ticks_per_frame, 1);
     }
 
-    if( ctx->color_range == AVCOL_RANGE_JPEG )
+    /* FIXME we should only set the known values and let the core decide
+     * later of fallbacks, but we can't do that with a boolean */
+    switch ( ctx->color_range )
+    {
+    case AVCOL_RANGE_JPEG:
         fmt->b_color_range_full = true;
+        break;
+    case AVCOL_RANGE_UNSPECIFIED:
+        fmt->b_color_range_full = !vlc_fourcc_IsYUV( fmt->i_chroma );
+        break;
+    case AVCOL_RANGE_MPEG:
+    default:
+        fmt->b_color_range_full = false;
+        break;
+    }
 
     switch( ctx->colorspace )
     {
-- 
2.14.2



More information about the vlc-devel mailing list