[vlc-devel] [PATCH 2/8] sout_mux/core: handle drain

[Thomas Guillem]

On Mon, Jan 29, 2018, at 19:33, Rémi Denis-Courmont wrote:
> Le maanantaina 29. tammikuuta 2018, 19.25.50 EET Thomas Guillem a écrit :
> > Like for decoder_t, a drain is requested when sending/writing a NULL block.
> > 
> > Muxers should drain themselves when they receive the last pf_delstream
> > callback (call the new sout_MuxIsDrained() helper to know when it happens).
> 
> I do not agree there. If it is possible to add and remove ES's dynamically, it 
> should be possible to remove all of them, then add new ones. This is neither 
> sufficient nor necessary a condition to drain the muxer.

There should be 2 muxers categories: one like TS that can handle ES dynamically .And others like mkv that can't cope with streams change when they are already started (see the ugly sout-mux-caching option).

> 
> Muxers should "drain" up to the PCR, regardless of any ES or even the whole 
> stream ending. Of course, that requires passing the PCR (or its translation) 
> to the stream outputs and muxers.
> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel