[vlc-devel] [PATCH 5/8] httpd/core: handle stream drain

[Rémi Denis-Courmont]

Le tiistaina 30. tammikuuta 2018, 10.29.24 EET Thomas Guillem a écrit :
> On Mon, Jan 29, 2018, at 19:47, Rémi Denis-Courmont wrote:
> > Le maanantaina 29. tammikuuta 2018, 19.25.53 EET Thomas Guillem a écrit :
> > > When calling httpd_StreamSend(stream, NULL).
> > 
> > What is the point in that relative complexity? Is there a use case for
> > keeping the current behaviour of stalling the client when the stream is
> > deleted?
> I need it for chromecast.

You need to conditionally stall the Chromecast HTTP client on a dead stream? 
That seems dubious.

AFAICT, the connection should be inconditionally closed when the stream is 
deleted. With that said, this is not something that HTTPd supports. It has 
always been assumed that the client will go away before the stream is deleted. 
Otherwise, I expect some use-after-free or such.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/