[vlc-devel] [PATCH] core: Add atomic refcounter helper

Rémi Denis-Courmont remi at remlab.net
Sun Jul 1 20:48:03 CEST 2018


Le sunnuntaina 1. heinäkuuta 2018, 20.56.03 EEST Romain Vimont a écrit :
> On Sun, Jul 01, 2018 at 08:10:54PM +0300, Rémi Denis-Courmont wrote:
> > Le sunnuntaina 1. heinäkuuta 2018, 12.30.33 EEST Romain Vimont a écrit :
> > > On Sun, Jul 01, 2018 at 11:59:08AM +0300, Rémi Denis-Courmont wrote:
> > > > Furthermore the boolean evaluation of the return value is the opposite
> > > > of
> > > > what any other ref counting API does (other than VLC's). Usually, zero
> > > > is
> > > > for last reference and non-zero for non-last references. Again, this
> > > > is
> > > > prone to errors.
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/
> > > lib/ refcount.c?h=v4.17#n208
> > 
> > This is very new.
> 
> In 2009, there were already atomic_dec_and_test(), with the same
> behavior:
> <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/inc
> lude/asm-generic/atomic.h?h=v2.6.31#n123>

So what?

There was atomic_dec_return() before, and it was still used for reference 
counting until recently.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list