[vlc-devel] [V3 3/3] libvlc: support setting seek mode

[Hugo Beauzée-Luyssen]

On Sat, Jun 30, 2018, at 11:13 PM, Zhao Zhili wrote:
> On Sat, 2018-06-30 at 22:48 +0300, Martin Storsjö wrote:
> > On Mon, 25 Jun 2018, Zhao Zhili wrote:
> > 
> > > ---
> > > include/vlc/libvlc_media_player.h | 10 ++++++++--
> > > lib/media_player.c                | 18 ++++++++++--------
> > > 2 files changed, 18 insertions(+), 10 deletions(-)
> > > 
> > > diff --git a/include/vlc/libvlc_media_player.h
> > > b/include/vlc/libvlc_media_player.h
> > > index 9ef1dde..87d3368 100644
> > > --- a/include/vlc/libvlc_media_player.h
> > > +++ b/include/vlc/libvlc_media_player.h
> > > @@ -785,9 +785,12 @@ LIBVLC_API libvlc_time_t
> > > libvlc_media_player_get_time( libvlc_media_player_t *p_
> > >  * Not all formats and protocols support this.
> > >  *
> > >  * \param p_mi the Media Player
> > > + * \param b_fast prefer fast seeking or precise seeking
> > >  * \param i_time the movie time (in ms).
> > > + * \return 0 on success, -1 on error
> > >  */
> > > -LIBVLC_API void libvlc_media_player_set_time(
> > > libvlc_media_player_t *p_mi, libvlc_time_t i_time );
> > > +LIBVLC_API int libvlc_media_player_set_time( libvlc_media_player_t
> > > *p_mi,
> > > +                                             libvlc_time_t i_time,
> > > bool b_fast );
> > > 
> > 
> > Since this changed public libvlc API, libvlcpp also needs a
> > corresponding 
> > update. Currently this breaks win32 builds (at least mine), where 
> > vlc-npapi fails to build due to libvlcpp referencing a version of
> > this 
> > function with only 2 parameters.
> 
> Update to the new API is straightforward, but I don't know how to send
> the patch since there is no libvlcpp mailing list.
> 
> > 
> > // Martin

IMHO sending them to vlc-devel is fine, or you can send them to me directly :)

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr