[vlc-devel] [PATCH v2 01/10] core: add atomic refcounter helper

[Hugo Beauzée-Luyssen]

On Mon, Jul 2, 2018, at 8:12 AM, Rémi Denis-Courmont wrote:
> Same problems as before.
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

> - type sizes (uint, uintptr...),

The serie only affect code that was using uint, except for patch 4 that was using uintptr, and I believe uint to be a better fit; and patch 10. I'm fine with dropping patch 10 for now.

> - order on decrement - acq_rel is not always needed,

I believe it is.

> - corner cases where the decrement is known to not reach zero,

Then don't use the helper in that case?

> - corner cases where the decrement cannot be permitted to reach zero(e.g. vlc_object_t, IIRC).

Ditto.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr