[vlc-devel] [V3 PATCH 0/3] lock aout/vout and fix pause/rate state inconsistency

Thomas Guillem thomas at gllm.fr
Tue Jul 3 12:53:38 CEST 2018


On Tue, Jul 3, 2018, at 12:06, Rémi Denis-Courmont wrote:
> Yeah. I suspect it would be simpler overall to have the aout/vout at
> all times in the decoder and allow changing pause and rate even if
> there is no active output format.
Yes, I also tried to call directly aout/vout pause/rate function from
the input thread (like input_DecoderChangePause) but the
vout_ChangePause function may be blocking. Maybe we can make it fully
asynchronous by removing the call to vout_control_WaitEmpty().
> 
>  At least aout is already almost ready for that.
> 
> Le 3 juillet 2018 12:15:49 GMT+03:00, Thomas Guillem <thomas at gllm.fr>
> a écrit :>> V2 can be found here: https://patches.videolan.org/patch/21082/
>> 
>> 
>> 
>> Difference between V2 and V3: adding a third patch that fix the
>> pause/rate
>>>> state when the output is restarted.
>> 
>> 
>> 
>> Thomas Guillem (3):
>> 
>>   dec: lock aout/vout when read from DecoderThread
>> 
>>   dec: fix pause/rate not handled
>> 
>>   dec: update pause/rate when the output is restarted
>> 
>> 
>> 
>>  src/input/decoder.c | 100 +++++++++++++++++++++++++++++++-------------
>>>>  1 file changed, 72 insertions(+), 28 deletions(-)
>> 
> 
> --
>  Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>  excuser ma brièveté.> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180703/dc4dbfde/attachment.html>


More information about the vlc-devel mailing list