[vlc-devel] [PATCH v3 04/10] core: use refcounter helper for pictures

Romain Vimont rom1v at videolabs.io
Tue Jul 3 22:17:14 CEST 2018


On Tue, Jul 03, 2018 at 09:10:24PM +0300, Rémi Denis-Courmont wrote:
> Le tiistaina 3. heinäkuuta 2018, 9.47.55 EEST Romain Vimont a écrit :
> > @@ -27,7 +26,7 @@ typedef struct
> >      picture_t picture;
> >      struct
> >      {
> > -        atomic_uintptr_t refs;
> > +        vlc_atomic_rc_t rc;
> 
> Wrong as already explained multiple times.

No reason has been provided to keep a different type for pictures from
any other refcounts. It seems the difference was accidental, so the
types should now be made consistent.


More information about the vlc-devel mailing list