[vlc-devel] [PATCH 1/4] vgl: provide a module to allow rendering in a user defined opengl context

[Rémi Denis-Courmont]

I objected to the union as well, so that's not an argument that I'd receive.

At least the current union breaks the abstraction unidirectionally. Not your patch, which breakd other GL provider users.

Le 4 juillet 2018 11:06:35 GMT+03:00, Pierre Lamot <pierre at videolabs.io> a écrit :
>> I don't really see why this needs to be exposed here. Virtualized
>plugins 
>> generally call the initialization and deinitialization callbacks
>in-situ.
>
>AFAIK, opengl modules don't have access to the picture size. 
>
>> In fact, it looks like breaking the existing abstraction.
>
>Isn't this union purpose to break abstraction and handle special cases?
>
>--
>Pierre Lamot

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180704/301ff14b/attachment.html>