[vlc-devel] [PATCH 2/4] vgl: expose opengl callbacks through libvlc
Rémi Denis-Courmont
remi at remlab.net
Wed Jul 4 19:26:16 CEST 2018
Le keskiviikkona 4. heinäkuuta 2018, 17.46.16 EEST Pierre Lamot a écrit :
> Concerning the create(size)/destroy callbacks, we can get the informations
> from the resize callback in opengl module. The main advantage is that it
> rely on existing mechanism and doesn't interfere with vout_helper. Though I
> see some drawbacks:
> - resize callback isn't call with opengl context. though, we can still
> enforce that.
> - we won't get notified when the resources aren't needed
> anymore.
> - resize is called several times, without actual size changes.
>
> For actual resize, as far as I understand, the opengl module is closed and
> reopen on format change, so the case seems handled in the V1 of my patches.
I don't think you can rely on that. Track change will change the vout, sure.
But e.g. source crop or source A/R change will not.
And then, the dummy window provider will trigger unintended size requests.
You need a new window type if you don't want that.
--
レミ・デニ-クールモン
http://www.remlab.net/
More information about the vlc-devel
mailing list