[vlc-devel] [PATCH 4/4] vgl: add option to inhibit 360 and stereo projection

Rémi Denis-Courmont remi at remlab.net
Wed Jul 4 19:33:59 CEST 2018

Le tiistaina 3. heinäkuuta 2018, 15.38.37 EEST Pierre Lamot a écrit :
> ---
>  include/vlc_opengl.h                      |  1 +
>  modules/video_output/opengl/vout_helper.c | 23 ++++++++++++++++++-----
>  modules/video_output/vgl.c                |  9 +++++++++
>  3 files changed, 28 insertions(+), 5 deletions(-)
> diff --git a/include/vlc_opengl.h b/include/vlc_opengl.h
> index f9329c7675..618bbcd56e 100644
> --- a/include/vlc_opengl.h
> +++ b/include/vlc_opengl.h
> @@ -82,6 +82,7 @@ struct vlc_gl_t
>              void (*destroyCb)(void *p_opaque);
>              void (*renderCb)(void *p_opaque, bool enter);
>              void *p_opaque;
> +            bool b_force_no_projection;

Normally, I would think that the projection should be gathered by the 
windowing system from display configuration (or prefs), to the core, and from 
the core to the vout display. So the GL provider is not involved. At least, so 
far the view angle is already controlled from the core to the display.

Obviously, given that this patch series uses wdummy, such a mechanism wouldn't 
work even if the core had it implemented - it would also need a custom window 
type and provider.

But well, leaving that aside, I don't see a mechanism for the app to get 
projection data, so how is that option going to work in the grand scheme of 
things? I'd rather not expose an option for an as yet unimplemented feature.


More information about the vlc-devel mailing list