[vlc-devel] [PATCH] core: move input.c to input_internal.c

Rémi Denis-Courmont remi at remlab.net
Fri Jul 6 19:33:22 CEST 2018


Le perjantaina 6. heinäkuuta 2018, 20.26.54 EEST Thomas Guillem a écrit :
> On Fri, Jul 6, 2018, at 19:20, Rémi Denis-Courmont wrote:
> > Le torstaina 5. heinäkuuta 2018, 17.22.43 EEST Thomas Guillem a écrit :
> > > Leave input.c for the future "input manager", that will be called
> > > vlc_input_t.
> > 
> > Well if you want... but why don't you just call the input manager input
> > manager?
> 
> I want the input manager to become the new main input API, so completely
> hide input thread, and don't use var to control or get notified anymore.

I am not versed but I believe that normal people would call that thing a 
player, not an input though.

> This new input will use one or two input thread (in case of gapeless).
> 
> Is that a good start plan ?

It sounds rather ambitious for a "start" plan.

> For the name, manager or not, I don't really care but some people hate
> manager it seems...

Then call it input thread factory.

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list