[vlc-devel] [PATCH 2/5] modules: make use of the special duration value INPUT_UNKNOWN_DURATION

Steve Lhomme robux4 at ycbcr.xyz
Sat Jul 7 09:10:09 CEST 2018

On 2018-07-06 18:29, Rémi Denis-Courmont wrote:
> Le perjantaina 6. heinäkuuta 2018, 15.18.53 EEST Steve Lhomme a écrit :
>> On 2018-06-23 9:53, Rémi Denis-Courmont wrote:
>>> The duration of vlc://nop is *not* unknown. It's zero.
>> It's not always the case, in lua/sd and xcb_apps it's initialized to -1.
> In those cases, there was confusion whether the item is supposed to include
> the duration of children or not. In XCB apps, the duration of each children is
> obviously unknown.

You say "obviously" very liberally. It may be obvious to you but since I 
don't even know what XCB is, I don't see how it could be obvious to me 
or anyone just reading the code.

> Still I meant that the actual duration of vlc://nop is always zero.

OK, so I understand it as these two occurences should be changed to use 
0 (and not VLC_TICK_INVALID).

> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list