[vlc-devel] [PATCH] core: the earliest we can flush is VLC_TICK_0

[Rémi Denis-Courmont]

Le lauantaina 7. heinäkuuta 2018, 19.03.29 EEST Denis Charmet a écrit :
> On 2018-07-03 11:07, Rémi Denis-Courmont wrote:
> > I don't understand why there is even a time parameter here. Audio has
> > a wait flag to differentiate flush (drop) and drain (dequeue).
> > 
> >  What is the meaning of the time parameter? Shouldn't it be removed?
> 
> Isn't it because pictures being a discrete stream, a picture "drain"
> would need some kind of duration and the time value would provide the
> end date?

IMU, draining the FIFO means to wait until the content of the FIFO has been 
rendered and the FIFO is empty, while flusing the FIFO means to discard 
everything ASAP. At least, that's how it works in audio output.

I don't understand what the date parameters does in that context. The pictures 
in the FIFO already have a date field to know when and how long to show them.

Typically, you drain on EOS (to avoid losing last few frames), and you flush 
on explicit stop or seek.

-- 
Реми Дёни-Курмон
http://www.remlab.net/