[vlc-devel] [patch] pulseaudio API compatibility fix

[jnqnfe at gmail.com]

On Fri, 2018-07-06 at 20:34 +0300, Rémi Denis-Courmont wrote:
> Le perjantaina 6. heinäkuuta 2018, 20.27.43 EEST Rémi Denis-Courmont
> a écrit :
> > Patch is giving ugly warnings here.
> 
> ../../modules/audio_output/pulse.c: In function ‘stream_start’:
> ../../modules/audio_output/pulse.c:248:46: warning: passing argument
> 3 of 
> ‘pa_context_rttime_new’ from incompatible pointer type [-
> Wincompatible-
> pointer-types]
>                                               stream_trigger_cb,
> aout);
>                                               ^~~~~~~~~~~~~~~~~
> In file included from /usr/include/pulse/pulseaudio.h:29:0,
>                  from ../../modules/audio_output/pulse.c:35:
> /usr/include/pulse/context.h:263:16: note: expected
> ‘pa_time_event_cb_t {aka 
> void (*)(struct pa_mainloop_api *, struct pa_time_event *, const
> struct 
> timeval *, void *)}’ but argument is of type ‘void (*)(const
> pa_mainloop_api 
> *, pa_time_event *, const struct timeval *, void *) {aka void
> (*)(const struct 
> pa_mainloop_api *, struct pa_time_event *, const struct timeval *,
> void *)}’
>  pa_time_event* pa_context_rttime_new(pa_context *c, pa_usec_t usec, 
> pa_time_event_cb_t cb, void *userdata);
>                 ^~~~~~~~~~~~~~~~~~~~~
> 
> Can't we have something that works nicely with existing versions??

Well, the only other solution I can think of would be to use #ifdef's
to compare the version in the header, which would thus avoid the
warning, but there's no concrete version number for when this change
may be published...

We could just put a pin in this for now if you like, until we get
closer to an actual PA release containing the change.