[vlc-devel] [PATCH 2/2] extras/tools: Check for libtool before automake

[Hugo Beauzée-Luyssen]

On Wed, Jul 11, 2018, at 11:35 AM, Hugo Beauzée-Luyssen wrote:
> This way automake will be built before libtool if needed
> ---
>  extras/tools/bootstrap | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extras/tools/bootstrap b/extras/tools/bootstrap
> index 80c248b808..8ba4a99294 100755
> --- a/extras/tools/bootstrap
> +++ b/extras/tools/bootstrap
> @@ -117,10 +117,10 @@ else
>  fi
>  }
>  
> +check libtool 2.4
>  check autoconf 2.69
>  check automake 1.15
>  check m4 1.4.16
> -check libtool 2.4
>  check pkg-config
>  check cmake 3.8.2
>  check yasm
> -- 
> 2.18.0
> 

Quick side node for this patch: I don't think that's enough because in case of a parallel build, there's no guarantee automake will be built before libtool. 
That being said, most of the tools require automake or other tools, so that's an existing issue.
The alternative I can think of is to output .<target> files when the presence/version check succeeds, and remove those files when adding a target to NEEDED while running bootstrap.

Opinions welcome!

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr