[vlc-devel] [PATCH] configure: Don't force _WIN32_WINNT to 0x0601 if it is set to a higher version
robux4 at ycbcr.xyz
Fri Jul 13 07:53:49 CEST 2018
On 2018-07-13 7:16, Steve Lhomme wrote:
>> On 12 Jul 2018, at 20:56, Martin Storsjö <martin at martin.st> wrote:
>>> On Thu, 12 Jul 2018, Steve Lhomme wrote:
>>> There are many things here:
>>> - _WIN32_WINNT was set conditionally and unconditionally (conditionally is right)
>>> - it was overridden by the unconditional part when set to a newer/older value than 0x0601, that part should just go away
>>> - the intent of the conditional part is that the default is 0x0601 but any other value would work. Your patches changes that and don't allow forcing building for older targets. I don't think it's necessary/right.
>> Well afaik we don't intend to support building for anything older. But I changed that part when I fixed this later this morning.
>>> Simply removing the AC_DEFINE() line was sufficient.
>> Yes, that was what I thought initially as well (which makes the referenced commit e807c8e91 look even stranger). But the reason for that commit was that the previous block of ifdefs, added via AH_TOP, weren't taken into account when running other tests in configure, which was e807c8e91 added. But I changed it all to a preprocessor check in configure, and only then adding it via AC_DEFINE.
> Yes it's a lot better. You might turn it into a general m4 function. Maybe AC_DEFINE could use it to allow overriding for specific builds.
>> // Martin
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel