[vlc-devel] [PATCH 2/5] input: add DEMUX_VOUT_CHANGED

Thomas Guillem thomas at gllm.fr
Fri Jul 13 18:51:40 CEST 2018



On Fri, Jul 13, 2018, at 18:32, Rémi Denis-Courmont wrote:
> Le perjantaina 13. heinäkuuta 2018, 12.34.38 EEST Thomas Guillem a écrit :
> > This control allow to propagate vout events from the decoder to the demux.
> 
> To me, it feels backward to have the demuxer track the video output, 
> regardless if it's done with an input thread event or a demuxer control.
> 
> Mouse events should be dispatched like key events already are, e.g.:
> 
> const vlc_mouse_t *state;
> 
> if (demux_Control(demux, DEMUX_NAV_MOUSE, state) != VLC_SUCCESS)
>     /* Generic mouse processing, fullscreen toggle or whatever */;
> else
>     /* Mouse event eaten by demuxer. Drop. */;
> 

What about the delay from the input mainloop ?

I agree, demuxers should leave the vout alone. 

That's why a did a second version : cf. "[V2 PATCH 1/2] es_out: add ES_OUT_SET_VOUT_MOUSE_CALLBACKS"

What do you think ?
> And otherwise, the demuxer really should live the video output(s) alone IMO.
> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list