[vlc-devel] [PATCH] qt: Autoplay video when entering fullscreen

[Marvin Scholz]

On 15 Jul 2018, at 15:48, Vaishnav Sivadas wrote:

> Hi,
>
> What change are you suggesting which could improve the patch?

What is definitely needed is a setting to turn this behavior on
or off.

>
> On Sun, Jul 15, 2018 at 7:13 PM Marvin Scholz <epirat07 at gmail.com> wrote:
>
>> Hi, thanks for your patch.
>>
>> I am not sure though if doing this in a specific interface only
>> (in this case the qt interface) is a good solution.
>>
>> On 15 Jul 2018, at 15:40, Vaishnav Sivadas wrote:
>>
>>> Autoplays a video upon entering full screen which enhances UX
>>>
>>> fixes #8533
>>> ---
>>>  modules/gui/qt/input_manager.cpp | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/modules/gui/qt/input_manager.cpp
>>> b/modules/gui/qt/input_manager.cpp
>>> index 4c28933395..c94cffe164 100644
>>> --- a/modules/gui/qt/input_manager.cpp
>>> +++ b/modules/gui/qt/input_manager.cpp
>>> @@ -1287,5 +1287,11 @@ int MainInputManager::PLItemRemoved(
>>> vlc_object_t *obj, const char *,
>>>  void MainInputManager::changeFullscreen( bool new_val )
>>>  {
>>>      if ( var_GetBool( THEPL, "fullscreen" ) != new_val)
>>> +    {
>>>          var_SetBool( THEPL, "fullscreen", new_val );
>>> +    }
>>> +    if (new_val)
>>> +    {
>>> +        playlist_Play( THEPL );
>>> +    }
>>>  }
>>> --
>>> 2.17.1
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>
>
> -- 
> Vaishanav Sivadas
> Amrita University.
> Wordpress <https://vaishnavsivadas.wordpress.com/> | Github
> <https://github.com/vaishnavsivadas>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel