[vlc-devel] [PATCH] qt: Autoplay video when entering fullscreen

[Rémi Denis-Courmont]

I also think that this should be done in the common PL code rather than Qt. Like the Trac ticket is hinting, in fact.

And it probably needs an option, though I don't know what the default should be.

Le 15 juillet 2018 16:43:04 GMT+03:00, Marvin Scholz <epirat07 at gmail.com> a écrit :
>Hi, thanks for your patch.
>
>I am not sure though if doing this in a specific interface only
>(in this case the qt interface) is a good solution.
>
>On 15 Jul 2018, at 15:40, Vaishnav Sivadas wrote:
>
>> Autoplays a video upon entering full screen which enhances UX
>>
>> fixes #8533
>> ---
>>  modules/gui/qt/input_manager.cpp | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/modules/gui/qt/input_manager.cpp 
>> b/modules/gui/qt/input_manager.cpp
>> index 4c28933395..c94cffe164 100644
>> --- a/modules/gui/qt/input_manager.cpp
>> +++ b/modules/gui/qt/input_manager.cpp
>> @@ -1287,5 +1287,11 @@ int MainInputManager::PLItemRemoved( 
>> vlc_object_t *obj, const char *,
>>  void MainInputManager::changeFullscreen( bool new_val )
>>  {
>>      if ( var_GetBool( THEPL, "fullscreen" ) != new_val)
>> +    {
>>          var_SetBool( THEPL, "fullscreen", new_val );
>> +    }
>> +    if (new_val)
>> +    {
>> +        playlist_Play( THEPL );
>> +    }
>>  }
>> -- 
>> 2.17.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180715/61871e3f/attachment.html>