[vlc-devel] [PATCH] qt: Autoplay video when entering fullscreen

[David Fuhrmann]

Hi,

I would advise you to first implement the feature in core and add the option itself.
Adding to to the simple preferences can be done afterwards, if we feel its important enough. I would probably add it to the video section.

BR. David

> Am 15.07.2018 um 18:31 schrieb Vaishnav Sivadas <vaishnavsivadas at gmail.com>:
> 
> Hi again, 
> Sorry, a correction there. I guess it would be perfect if it comes inside Video section in Tools->Preferences->Video. Any suggestions guys? Shall I proceed with it?
> 
> 
> On Sun, Jul 15, 2018 at 9:39 PM Vaishnav Sivadas <vaishnavsivadas at gmail.com <mailto:vaishnavsivadas at gmail.com>> wrote:
> Hi,
> Will it be okay, if I add a toggle option in the look and feel section which comes in Preferences->Interface? If not, what can be done to make the feature more convenient?
> 
> On Sun, Jul 15, 2018 at 7:32 PM Alexandre Janniaux <alexandre.janniaux at gmail.com <mailto:alexandre.janniaux at gmail.com>> wrote:
> Hi,
> 
> Thank you for taking the time to make this patch! However, it doesn't seem to be what the ticket is saying. It will force this new behaviour for Qt whereas the ticket's suggestion is to add a new parameter to enable this feature.
> 
> There is also the behaviour consistency issue when using another interface as mentionned by Marvin.
> 
> I don't know if this feature is really wanted by many people, but maybe you could add this new parameter and update the other interfaces. I believe it would be difficult to find a common location for it as this feature might not really be wanted for libvlc and is only related to interfaces themselves.
> 
> 
> 2018-07-15 15:48 GMT+02:00 Vaishnav Sivadas <vaishnavsivadas at gmail.com <mailto:vaishnavsivadas at gmail.com>>:
> Hi,
> 
> What change are you suggesting which could improve the patch?
> 
> On Sun, Jul 15, 2018 at 7:13 PM Marvin Scholz <epirat07 at gmail.com <mailto:epirat07 at gmail.com>> wrote:
> Hi, thanks for your patch.
> 
> I am not sure though if doing this in a specific interface only
> (in this case the qt interface) is a good solution.
> 
> On 15 Jul 2018, at 15:40, Vaishnav Sivadas wrote:
> 
> > Autoplays a video upon entering full screen which enhances UX
> >
> > fixes #8533
> > ---
> >  modules/gui/qt/input_manager.cpp | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/modules/gui/qt/input_manager.cpp 
> > b/modules/gui/qt/input_manager.cpp
> > index 4c28933395..c94cffe164 100644
> > --- a/modules/gui/qt/input_manager.cpp
> > +++ b/modules/gui/qt/input_manager.cpp
> > @@ -1287,5 +1287,11 @@ int MainInputManager::PLItemRemoved( 
> > vlc_object_t *obj, const char *,
> >  void MainInputManager::changeFullscreen( bool new_val )
> >  {
> >      if ( var_GetBool( THEPL, "fullscreen" ) != new_val)
> > +    {
> >          var_SetBool( THEPL, "fullscreen", new_val );
> > +    }
> > +    if (new_val)
> > +    {
> > +        playlist_Play( THEPL );
> > +    }
> >  }
> > -- 
> > 2.17.1
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel <https://mailman.videolan.org/listinfo/vlc-devel>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel <https://mailman.videolan.org/listinfo/vlc-devel>
> 
> -- 
> Vaishanav Sivadas
> Amrita University.
> Wordpress <https://vaishnavsivadas.wordpress.com/> | Github <https://github.com/vaishnavsivadas> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel <https://mailman.videolan.org/listinfo/vlc-devel>
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel <https://mailman.videolan.org/listinfo/vlc-devel>
> 
> -- 
> Vaishanav Sivadas
> Amrita University.
> Wordpress <https://vaishnavsivadas.wordpress.com/> | Github <https://github.com/vaishnavsivadas> 
> 
> 
> -- 
> Vaishanav Sivadas
> Amrita University.
> Wordpress <https://vaishnavsivadas.wordpress.com/> | Github <https://github.com/vaishnavsivadas> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel <https://mailman.videolan.org/listinfo/vlc-devel>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180715/cdf99214/attachment.html>