[vlc-devel] [PATCH] core: access: change attachment handling

[Thomas Guillem]

On Fri, Jul 20, 2018, at 14:23, Steve Lhomme wrote:
> On 20/07/2018 12:51, Thomas Guillem wrote:
> > On Fri, Jul 20, 2018, at 12:19, Rémi Denis-Courmont wrote:
> >> Le mercredi 18 juillet 2018, 15:24:53 EEST Thomas Guillem a écrit :
> >>> And remove one more reference to the input_thread_t from accesses.
> >> I would remove that access altogether. Specifically, I would use stream_Memory
> >> instead of access to back the input source instead. (I don't know how much
> >> rework is needed within input core to make it happen though.)
> > For that, I need to find how this access is used.
> > Even when reading covert art from mp3/mp4 with attachement:// this access is not used, I don't get it.
> 
> It seems to be used in the bluray/flac/matroska/mp4/ogg modules with 
> cover art URLs. They all use "attachment://" URLs. All stored using 
> vlc_meta_ArtworkURL with can be cached by the preparser.

I know, and I'm able to see these covers with such demuxers but without using the attachement access. Yes I cleared my art cache.

> 
> >
> >> -- 
> >> Rémi Denis-Courmont
> >>
> >>
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel