[vlc-devel] [PATCH 3/3] input: item: ignore directories if --recursive=none

[Rémi Denis-Courmont]

Le vendredi 20 juillet 2018, 12:55:19 EEST Filip Roséen a écrit :
> Hi again,
> 
> As the patch in which this email is a reply to includes an
> *ABI*-breaking change, it cannot be backported to `3.0.0` *as-is*.
> 
> I am not sure how many users rely on `--recursive=none`, though it's
> probably not many as it has been broken for quite some time, and I
> could not find a single ticket or post that asks about the breakage.
> With that in mind we have a few options:
> 
>   1. remove support for `--recursive=none`, conditionally supporting
>      it in *trunk* (though if removed in one, it is probably best to
>      do it in both).
> 
>   2. write a somewhat ugly backportable fix

I suspect that --recursive can be removed altogether. We need a depth limit to 
prevent infinite recursion, and that effectively covers both none (depth=0 or 
1 maybe) and expand modes.

And the distinction between recursive and collapse mode is kind of hysterical 
raisins.

-- 
Rémi Denis-Courmont