[vlc-devel] [PATCH 3/3] input: item: ignore directories if --recursive=none

[Rémi Denis-Courmont]

Le samedi 21 juillet 2018, 08:30:43 EEST Filip Roséen a écrit :
> Hi Rémi,
> 
> On 2018-07-21 08:25, Rémi Denis-Courmont wrote:
> > Le vendredi 20 juillet 2018, 12:55:19 EEST Filip Roséen a écrit :
> > > Hi again,
> > > 
> > > As the patch in which this email is a reply to includes an
> > > *ABI*-breaking change, it cannot be backported to `3.0.0` *as-is*.
> > > 
> > > I am not sure how many users rely on `--recursive=none`, though it's
> > > probably not many as it has been broken for quite some time, and I
> > > could not find a single ticket or post that asks about the breakage.
> > > 
> > > With that in mind we have a few options:
> > >   1. remove support for `--recursive=none`, conditionally supporting
> > >   
> > >      it in *trunk* (though if removed in one, it is probably best to
> > >      do it in both).
> > >   
> > >   2. write a somewhat ugly backportable fix
> > 
> > I suspect that --recursive can be removed altogether. We need a depth
> > limit to prevent infinite recursion, and that effectively covers both
> > none (depth=0 or 1 maybe) and expand modes.
> 
> Should we then deprecate `--recursive` first, introduce `--depth` and
> remove `--recursive` in the next release (ie. current *trunk*)? I
> believe we do need a fix for `3.0.0`, and I am not sure what the
> policy is on option removal between majors; do we have such policy?

I would mark recursive obsolete, fix the infinite recursion bug, and stop at 
that, assuming that nobody really uses recursion=none.

But if you want to implement a generalized depth integer parameter, I guess 
that's possible too.

-- 
Rémi Denis-Courmont