[vlc-devel] [PATCH] cc: Only reset line position if rollup mode changed

[Francois Cartegnie]

Le 20/07/2018 à 20:40, Devin Heitmueller a écrit :

> -            h->mode = EIA608_MODE_ROLLUP_2;
> +            proposed_mode = EIA608_MODE_ROLLUP_2;
>          else if( d2 == 0x26 )
> -            h->mode = EIA608_MODE_ROLLUP_3;
> +            proposed_mode = EIA608_MODE_ROLLUP_3;
>          else
> -            h->mode = EIA608_MODE_ROLLUP_4;
> +            proposed_mode = EIA608_MODE_ROLLUP_4;
>  
> -        h->cursor.i_column = 0;
> -        h->cursor.i_row = h->i_row_rollup;
> +        if ( proposed_mode != h->mode )
> +        {
> +            h->mode = proposed_mode;
> +            h->cursor.i_column = 0;
> +            h->cursor.i_row = h->i_row_rollup;
> +        }
>          break;
>      case 0x28:  /* Flash on */
>          /* TODO */
> 


Hi,

I can't really figure how it should behave on RU2, RU3, RU4,
as the spec only mentions differences in hw decoder and clearing of rollups.

I can't be sure if the command should be ignored, or only committed on
another one.

How does behave the 708 decoder with the same stream ?

-- 
Francois Cartegnie
VideoLAN - VLC Developer