[vlc-devel] [PATCH] avcodec: added skip-frames option for encoder

[Francois Cartegnie]

Le 26/07/2018 à 09:34, Paweł Wegner a écrit :
> No, it is not related to the decoder output. Decoder has `skip-frames`
> option as well, but it is not useful since it is
> the encoder which drops frames.
> My problem is that those timestamps are different every time I run the
> code. Looks like they are absolute,
> not relative to the beginning of the video. Is this intended?
> 
> On Thu, Jul 26, 2018 at 8:58 AM Steve Lhomme <robux4 at ycbcr.xyz> wrote:
> 
>> On 24/07/2018 21:59, Paweł Wegner wrote:
>>> Encoder will encode only one frame per timestamp. Since timestamps may be
>>> inaccurate, skipping frames may render encoder's output nondeterministic.
>>> Added an option which instructs to encode all frames which come out of
>> avcodec.
>>
>> Is this related to the output of the avcodec decoder ? Because that's
>> how I understand the commit log and doc of the option. But the option is
>> on the encoder, which may receive frames from other decoders.

They are scheduled on your system, so that's system clock.

I don't see how this patch can't break encoding with broken streams not
sending proper PTS or PTS at all.


-- 
Francois Cartegnie
VideoLAN - VLC Developer