[vlc-devel] [v4 00/10] Input duration cleaning

Steve Lhomme robux4 at ycbcr.xyz
Fri Jul 27 12:49:00 CEST 2018


I tried to use better name for the 2 special values we need:
- indefinite is for input items from live sources, so an indefinite (not finite)
  duration. I prefer that to not_finite as using negation in names is never
  a good thing.
- unset is for items that have no known duration when they are created and
  it may stay that way (nodes or directories are not updated with a duration
  AFAIK). The value is 0 (actually invalid) for now but it may change in the
  future, it's still useful to know if a duration is really 0 or really unset
  yet. For now only sgmib sets an actual value of 0 on some items and it may be
  incorrect (really meaning unset but can be updated later)

Steve Lhomme (10):
  vlc_input_item: rename INPUT_DURATION_INVALID to INPUT_DURATION_UNSET
  vlc_input_item: rename INPUT_DURATION_UNKNOWN to
    INPUT_DURATION_INDEFINITE
  podcast: set the podcat duration to unset when it cannot be parsed
  asx: the default duration of items is unset unless read properly
  modules: set 0 for items which value is actually 0
  vlc_input_item: remove INPUT_DURATION_ZERO
  input:item: the duration for card items is indefinite
  m3u: reset the duration between items to indefinite
  input:item: return 0 when the duration is indefinite, rather than -1
  input:item: return 0 when the duration is unset

 include/vlc_input_item.h              | 13 +++++++------
 modules/control/oldrc.c               |  2 +-
 modules/demux/playlist/asx.c          |  2 +-
 modules/demux/playlist/m3u.c          |  4 ++--
 modules/demux/playlist/podcast.c      |  2 +-
 modules/demux/playlist/sgimb.c        |  2 +-
 modules/lua/libs/sd.c                 |  3 ++-
 modules/lua/vlc.c                     |  2 +-
 modules/services_discovery/os2drive.c |  2 +-
 modules/services_discovery/sap.c      |  2 +-
 modules/services_discovery/udev.c     |  3 ++-
 modules/services_discovery/upnp.cpp   |  2 +-
 modules/services_discovery/windrive.c |  2 +-
 modules/services_discovery/xcb_apps.c |  3 ++-
 src/input/item.c                      |  8 ++++++--
 src/playlist/tree.c                   |  2 +-
 test/libvlc/media.c                   |  2 +-
 17 files changed, 32 insertions(+), 24 deletions(-)

-- 
2.17.0



More information about the vlc-devel mailing list