[vlc-devel] [PATCH] demux: ts: fixed duration probing

jeremy.vignelles at dev3i.fr jeremy.vignelles at dev3i.fr
Thu Jun 7 09:27:48 CEST 2018


Hello,
Is there anything else you need to apply this patch?

-----Message d'origine-----
De : vlc-devel <vlc-devel-bounces at videolan.org> De la part de jeremy.vignelles at dev3i.fr
Envoyé : jeudi 31 mai 2018 10:04
À : 'Mailing list for VLC media player developers' <vlc-devel at videolan.org>
Objet : Re: [vlc-devel] [PATCH] demux: ts: fixed duration probing

Hi,
Any update on this?

-----Message d'origine-----
De : vlc-devel <vlc-devel-bounces at videolan.org> De la part de jeremy.vignelles at dev3i.fr Envoyé : lundi 28 mai 2018 14:23 À : 'Mailing list for VLC media player developers' <vlc-devel at videolan.org> Objet : Re: [vlc-devel] [PATCH] demux: ts: fixed duration probing

Hello, and thanks for your time 😊

In that case, it would enter the do/while loop. ProbeChunk would fail because it can't read the packet.
Then, at the while statement,  the condition will be false (i_pos < i_stream_size for ProbeStart and i_pos > 0 for ProbeEnd will be false).
I don't know if that behavior is correct, but it is the same as the current behavior.

-----Message d'origine-----
De : vlc-devel <vlc-devel-bounces at videolan.org> De la part de Francois Cartegnie Envoyé : lundi 28 mai 2018 14:08 À : vlc-devel at videolan.org Objet : Re: [vlc-devel] [PATCH] demux: ts: fixed duration probing

Le 28/05/2018 à 10:17, jeremy.vignelles at dev3i.fr a écrit :
> Hello,
> Can someone review my patch?
> 
> Do you want me to send an example file so that you can see the problem?

I haven't had time to test, but there's cases where the stream size is 0. (unknown)



--
Francois Cartegnie
VideoLAN - VLC Developer
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list