[vlc-devel] [PATCH] packetizer: initialize all callback fields and reorder some initialization

[Rémi Denis-Courmont]

The small difficulty is that some modules use the same activation callback for decoder and packetizer. They need to be separated first.

But yes.

Le 7 juin 2018 10:50:14 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Thu, Jun 7, 2018, at 05:48, Zhao Zhili wrote:
>> 
>> On 2018年06月07日 01:26, Rémi Denis-Courmont wrote:
>> > Le perjantaina 1. kesäkuuta 2018, 9.19.54 EEST Zhao Zhili a écrit :
>> >> A failed module probe may set the callback fileds point to that
>module.
>> > Do we actually ever need both callbacks at the same time? They look
>like
>> > candidates for union.
>> >
>> There are some works to do if we decide to merge pf_packetize and
>> pf_decode to a union. Some modules which can be used as codec and
>> packetizer set both callbacks unconditionally.
>
>These modules need to be fixed then (it should not be that hard no ?).
>Like rémi, I prefer having an union.
>
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180607/1a49a4ff/attachment.html>