[vlc-devel] [RFC] Moving services discovery out of the playlist

[Rémi Denis-Courmont]

Le sunnuntaina 10. kesäkuuta 2018, 18.45.34 EEST Romain Vimont a écrit :
> On Sun, Jun 10, 2018 at 06:08:12PM +0300, Rémi Denis-Courmont wrote:
> > Le sunnuntaina 10. kesäkuuta 2018, 17.14.43 EEST Romain Vimont a écrit :
> > > AFAIU, this is what happens at the playlist level currently (as a
> > > consequence, in the UI, items provided by the SD and by preparsing
> > > appear in a single tree).
> > 
> > No. The SD subtrees are currently expressly marked read-only in the
> > playlist mapping. The SD adds and removes items via SD callbacks or input
> > item node callbacks.
> 
> IIUC, this is what happens here.
> 
> The SD adds and removes items via SD callbacks:
> 
> <https://github.com/rom1v/vlc/blob/sd/src/media_browser/media_browser.c#L61>

Perhaps, but the document submitted for review does not separate write access 
from read access to the tree in any way, implying that it's free for all.

> or input item node callbacks:
> 
> <https://github.com/rom1v/vlc/blob/sd/src/media_tree/media_tree.c#L131>

Input item node callbacks need to die.
They cannot be used without lock inversion or almost.

But that is a separate and preexisting issue.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/