[vlc-devel] [PATCH] xdg_shell needs to be fully configured

erwan.tulou at gmail.com erwan.tulou at gmail.com
Tue Jun 12 16:14:43 CEST 2018


Hello,

    One more (important) patch to improve xdg_shell.

    the Wayland documentation makes it explicit that no buffer must be 
attached or committed before an xdg surface is fully configured. 
(ack_configure sent).
    Therefore, the xdg_shell vout window must ensure that the 
ack_configure() has been sent before handing over the surface handler to 
be used.

    On Weston, the bug is straightforward with the following message : 
error: xdg_surface at 9: error 3: xdg_surface has never been configured

    On Gnome Mutter, no error message, but the surface is buggy. Among 
other things, the geometry of the surface keeps being forgotten (reset 
to w=1, h=1 without any reason). The patch seems
to solve this bug.

Rgds

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-xdg_shell-provide-a-fully-configured-window.patch
Type: text/x-patch
Size: 1933 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180612/639be060/attachment.bin>


More information about the vlc-devel mailing list