[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

[Francois Cartegnie]

Le 19/06/2018 à 20:48, Rémi Denis-Courmont a écrit :
> Le tiistaina 19. kesäkuuta 2018, 21.41.00 EEST Francois Cartegnie a écrit :
>> We already have many broken ways to pass data belonging or depending on
>> block boundary (p_description, metadata in esformat, ...). Creating new
>> channels just to extract forward reorder and rebind data over fifos,
>> esout, modules and others, when it just refers to the data block, is
>> just another bloat.
> 
> Everytime that a component was bypassed or passed through, it ended badly.
> 
> The ES output needs to know what to do with the side data from the demuxer. 

It does not. Only the target, which is the decoder, does.
(and then decoder might pass/set/use sidedata params on picture)

Timeshift does need either to know. If it drops the block, it
automatically drops its sidedata, which again, only applies to that
sample/block.

With one exception, if that's encryption, we'll need to create a layer
to handle decryption at es_out level, so we can do sample decryption for
every demux and proxyed demux or though any layers we have.

If a packetizer is in the way, that means demux couldn't provide
sidedata anyway. Then it's its jobs to produce sidedata. In worst case
that's duplicated and same type gets replaced.

-- 
Francois Cartegnie
VideoLAN - VLC Developer