[vlc-devel] [PATCH 10/10] vlc_tick: add VLC_TICK_EPSILON to express the tiniest vlc_tick_t that can be used

[Steve Lhomme]

I found these pieces of code use 1 tick and I'm not sure this is correct:

http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/image.c;h=bc71b688d5aeec83f85d30aea9ebff789ed83819;hb=HEAD#l207
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/mkv/matroska_segment_seeker.cpp;h=1d1b18a88fdc2a5a706df7e30b76bf6ae54380bc;hb=HEAD#l322
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/mkv/mkv.cpp;h=a0e7e2bac217362feb881f829ed7a2dccf21738c;hb=HEAD#l689
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/mkv/mkv.cpp;h=a0e7e2bac217362feb881f829ed7a2dccf21738c;hb=HEAD#l734
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/mpeg/es.c;h=9d7948c9a3f237bd1f219bb5dff6330d41d47cfd;hb=HEAD#l355
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/mux/mp4/mp4.c;h=3165d8bceddbfc7197665ef49ea34305fa1fd346;hb=HEAD#l673
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/mux/mp4/mp4.c;h=3165d8bceddbfc7197665ef49ea34305fa1fd346;hb=HEAD#l685
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/mux/mp4/mp4.c;h=3165d8bceddbfc7197665ef49ea34305fa1fd346;hb=HEAD#l686
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/adaptive/logic/PredictiveAdaptationLogic.cpp;h=4e85f168868a47327c6723778a3aaeaabac5fe30;hb=HEAD#l47
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/adaptive/logic/PredictiveAdaptationLogic.cpp;h=4e85f168868a47327c6723778a3aaeaabac5fe30;hb=HEAD#l49
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/adaptive/Streams.cpp;h=5e0ad728d1dcbdb3359fd2959787ab56b86129fc;hb=HEAD#l123
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/smooth/playlist/ForgedInitSegment.cpp;h=f5ce10188aa4598f8059277a4b0fa1e731eea7e4;hb=HEAD#l218
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/smooth/SmoothManager.cpp;h=365c4cd6eb4f78b907ac0fc74dc14c0135bac5d3;hb=HEAD#l108
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/spu/rss.c;h=bd51456ea90a49d6a81cf02c7dd495167bd88149;hb=HEAD#l316
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/stream_filter/cache_block.c;h=8609382f9d6767da7433ac0bb340ed450c1b116f;hb=HEAD#l142
http://git.videolan.org/?p=vlc.git;a=blob;f=modules/stream_filter/cache_read.c;h=859529481b759c37a299a0831992c8887bf7da4f;hb=HEAD#l193

As my patch says, it probably means something is hackish and might be changed. Carrying over PTS/DTS/Length with an extra tick doesn't seem clean. In some cases it may mean VLC_TS_0 but I'm not sure.